[FFmpeg-cvslog] r14362 - trunk/libavcodec/ra288.c

[Michael Niedermayer]

On Thu, Jul 24, 2008 at 07:04:01AM +0200, Reimar D?ffinger wrote:
> Hello,
> On Thu, Jul 24, 2008 at 06:07:50AM +0200, vitor wrote:
> > Author: vitor
> > Date: Thu Jul 24 06:07:50 2008
> > New Revision: 14362
> > 
> > Log:
> > Follow FFmpeg convention of returning negative values on error in eval_lpc_coeffs()
> 
> Not that I want to complain, but I do not consider it a convention for
> internal functions that do not need to return any error codes.
> At least I will stay with 0/1 where it does not cause problems because
> it IMO results in more readable conditions...

IMO it does not, example

if(foobar(x))
    kungfoo(y);

is kungfoo(y) now called if foobar fails or succeeds?
You have to read foobar() to find out unless there is a convention.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No human being will ever know the Truth, for even if they happen to say it
by chance, they would not even known they had done so. -- Xenophanes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20080724/4a6689b8/attachment.pgp>