[FFmpeg-cvslog] r14267 - trunk/libavcodec/ra288.c

[Måns Rullgård]

Benoit Fouet <benoit.fouet at purplelabs.com> writes:

> M?ns Rullg?rd wrote:
>> Vitor Sessak <vitor1001 at gmail.com> writes:
>>   
>>> M?ns Rullg?rd wrote:
>>>     
>>>> Vitor Sessak <vitor1001 at gmail.com> writes:
>>>>
>>>>       
>>>>> Diego Biurrun wrote:
>>>>>         
>>>>>> On Fri, Jul 18, 2008 at 12:42:23AM +0200, vitor wrote:
>>>>>>           
>>>>>>> Log:
>>>>>>> Simplify
>>>>>>>             
>>>>>> Can we *please* have more descriptive commit messages?  How long can it
>>>>>> take you to explain *what* you simplified?
>>>>>>           
>>>>> For such obvious cleanups I'm against spending more time thinking about 
>>>>> the commit message than doing the code changes (even more so as what is 
>>>>> "cleaner" is a matter of taste, so it is non trivial to explain why the 
>>>>> new code is better in a commit msg). But if you could suggest anything 
>>>>> better that I could copy-paste for those kind of clean-up commits, I'd 
>>>>> happily do so.
>>>>>         
>>>> A simple "ra288:" prefix would suffice in this case.
>>>>       
>>> Then we go back to the flamewar about if the commit messages should be 
>>> understandable with or without seeing the list of changed files. From 
>>> what I followed of the discussion, this is a problem almost only for 
>>> git.
>>>     
>>
>> Here's some sample output from "svn log":
>>
>> ------------------------------------------------------------------------
>> r14274 | mru | 2008-07-18 02:07:17 +0100 (Fri, 18 Jul 2008) | 4 lines
>>
>> MPEGTS: Improve probe function
>>
>> When a sync byte is found, check that transport_error_indicator is zero,
>> and adaptation_field_control is valid (non-zero).
>> ------------------------------------------------------------------------
>> r14273 | bcoudurier | 2008-07-18 01:24:31 +0100 (Fri, 18 Jul 2008) | 1 line
>>
>> cosmetics, remove space
>> ------------------------------------------------------------------------
>> r14272 | bcoudurier | 2008-07-18 01:23:37 +0100 (Fri, 18 Jul 2008) | 1 line
>>
>> return max score when ftyp atom is encoutered
>> ------------------------------------------------------------------------
>> r14268 | vitor | 2008-07-17 23:59:53 +0100 (Thu, 17 Jul 2008) | 1 line
>>
>> Simplify
>> ------------------------------------------------------------------------
>> r14263 | diego | 2008-07-17 17:28:48 +0100 (Thu, 17 Jul 2008) | 3 lines
>>
>> Replace LDLATEFLAGS hackery by proper LDFLAGS tests.
>> The original reasons for LDLATEFLAGS are lost in the mists of time.
>>
>> ------------------------------------------------------------------------
>>
>> Looking at this, how would you know what was simplified in r14268?
>> Contrast this with the information given for r14274.
>
> come on, you just have to add a -v to your command line, and you'll get
> the changed path
> I really don't see the point of all this...

Damn it, you guys really are thick.  THE FILENAME IS NOT EVERYTHING.
Please, PLEASE, go back and read what I've written previously about
this.  I don't want to repeat it all over again.

-- 
M?ns Rullg?rd
mans at mansr.com