[FFmpeg-cvslog] r14168 - trunk/libavformat/psxstr.c

[Diego Biurrun]

On Fri, Jul 11, 2008 at 09:30:24PM +0200, Michael Niedermayer wrote:
> 
> On Fri, Jul 11, 2008 at 07:51:45PM +0100, M?ns Rullg?rd wrote:
> > Michael Niedermayer <michaelni at gmx.at> writes:
> > > The part which is changed should be mentioned only when its not obvious
> > > from the file changed.
> > >
> > > for git, git-log --stat will show you which files changed with the messages.
> > 
> > Not on a single line, and that's when it becomes most useful.
> 
> Then fix git, svn or whatever you use to display the information you want on
> a single line.

svn log -v

displays filenames affected by changes.

> > Besides, a change to files like utils.c or dsputils.c might be
> > affecting only one or two codecs, and in those cases it's nice
> > to know this.
> 
> yes, and it should be mentioned for these.
> A very bad example would be:
> 
> "SSE2 optimizations for Monkey's Audio decoder vector functions"
> 
> better would have been
> 
> "SSE2 optimizations of add/sub/scalarproduct_int16() which are currently
>  used only by the Monkey's Audio decoder"

Yes, that would be much better.

Commit messages around here are quite bad across the board.  This
completely conflicts with the goal of programming excellency that we
strive towards in general...

Diego