[FFmpeg-cvslog] r14168 - trunk/libavformat/psxstr.c

Måns Rullgård mans
Fri Jul 11 19:37:00 CEST 2008


Reimar D?ffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de> writes:

> On Fri, Jul 11, 2008 at 04:41:44PM +0100, M?ns Rullg?rd wrote:
>> 
>> michael wrote:
>> > Author: michael
>> > Date: Fri Jul 11 17:12:44 2008
>> > New Revision: 14168
>> >
>> > Log:
>> > simplify
>> 
>> Just as I was thinking the previous commit message was bad...
>
> I do not really mind that one, it is not (supposed to be) a functional
> change, so what "important" information is missing here? The affected
> file might not have hurt, but is seems a minor thing to me.

Yes, there is not supposed to be any functional change.  However, bugs
happen, and if I'm trying to figure out why something broke, it's nice
to be able to easily tell which commits might be relevant.  If the
commit message mentions psxstr, I know I can safely ignore it when
debugging some other format, for instance.  Seeing only "simplify", I
have to look at the diff to determine the irrelevance of this change.

I'm tempted to add a hook enforcing at least three words in a commit
message.  It is simply not possible to be accurate enough in only one
or two words.

-- 
M?ns Rullg?rd
mans at mansr.com




More information about the ffmpeg-cvslog mailing list