[FFmpeg-cvslog] r11690 - trunk/libavcodec/h263.c

[Michael Niedermayer]

On Wed, Jan 30, 2008 at 11:07:32PM -0500, Rich Felker wrote:
> On Thu, Jan 31, 2008 at 03:13:53AM +0100, michael wrote:
> > Author: michael
> > Date: Thu Jan 31 03:13:53 2008
> > New Revision: 11690
> > 
> > Log:
> > Comment about weird warning prevention.
> > 
> > 
> > Modified:
> >    trunk/libavcodec/h263.c
> > 
> > Modified: trunk/libavcodec/h263.c
> > ==============================================================================
> > --- trunk/libavcodec/h263.c	(original)
> > +++ trunk/libavcodec/h263.c	Thu Jan 31 03:13:53 2008
> > @@ -4727,7 +4727,7 @@ static inline int mpeg4_decode_block(Mpe
> >                                int n, int coded, int intra, int rvlc)
> >  {
> >      int level, i, last, run;
> > -    int dc_pred_dir= dc_pred_dir;
> > +    int dc_pred_dir= dc_pred_dir; //weird init to prevent uninitalized warning
> 
> This code is INVALID C and needs to be removed. A program containing
> this line has undefined behavior. Writing invalid C is not a
> legitimate way to silence gcc's bullshit warnings.

Well, then feel free ro revert it. Or ill revert it tomorrow 
(after some sleep ...)

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Opposition brings concord. Out of discord comes the fairest harmony.
-- Heraclitus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20080131/24651870/attachment.pgp>