[FFmpeg-cvslog] r11689 - trunk/libavcodec/h263.c

[Måns Rullgård]

Ismail D?nmez <ismail at pardus.org.tr> writes:

> At Thursday 31 January 2008 around 04:08:57 M?ns Rullg?rd wrote:
>> michael <subversion at mplayerhq.hu> writes:
>> > Author: michael
>> > Date: Thu Jan 31 02:38:00 2008
>> > New Revision: 11689
>> >
>> > Log:
>> > fix "uninitalized" warning, the alternative way.
>> >
>> > I hope this is valid C, flame me if not.
>> > md5sum of h263.o doesnt change, so this doesnt cause a slowdown.
>> >
>> > Modified:
>> >    trunk/libavcodec/h263.c
>> >
>> > Modified: trunk/libavcodec/h263.c
>> > =========================================================================
>> >===== --- trunk/libavcodec/h263.c	(original)
>> > +++ trunk/libavcodec/h263.c	Thu Jan 31 02:38:00 2008
>> > @@ -4727,7 +4727,7 @@ static inline int mpeg4_decode_block(Mpe
>> >                                int n, int coded, int intra, int rvlc)
>> >  {
>> >      int level, i, last, run;
>> > -    int dc_pred_dir;
>> > +    int dc_pred_dir= dc_pred_dir;
>>
>> Valid or not, the variable is just as uninitialised as before.  If
>> this silences a warning, that is a bug in gcc.
>
> As far as I know 
>
> int x = x;
>
> is undefined and gcc is free to do whatever.

Yes, which is why I consider it a bug to warn in once case and not the
other.

-- 
M?ns Rullg?rd
mans at mansr.com