[FFmpeg-cvslog] r11625 - trunk/libavformat/mov.c

[Reimar Döffinger]

Hello,
On Sun, Jan 27, 2008 at 04:15:01PM +0100, Baptiste Coudurier wrote:
> Reimar D?ffinger wrote:
> >> This is awfully hackish. IMHO codec id CODEC_ID_MOV_TEXT must be
> >> implemented and this mess must be done at the codec level.
> >> Please revert !
> > 
> > A CODEC_ID_MOV_TEXT is rather pointless with nobody supporting it, and
> > given the format I have some doubts it will ever be supported.
> 
> This is a bad justification for hacks.

It seems to be a good enough justification for all the hacks being
applied to the extradata...

> > In addition this was the way thing were handled for Matroska subtitles
> > at first as well...
> 
> One demuxer already doing hacks is not a justification either.

No, but the fact that it was considered an ok way back then did not make
me consider this a hack.

> > And lastly, while I miss the specifications to say for sure, the
> > subtitle format seems to be created on purpose the way that there is
> > first a pure plaintext version and then a formatted text version in one
> > packet, which makes this way to handle it seem much less hackish.
> 
> Data might be there on purpose and must be kept with stream copy.

I can not deny that (though this as well does not seem to apply to
e.g. extradata?)

> Extracting data can be done at bitstream parser and better at codec
> level if you want to get AVSubtitle structure.

I'd have to investigate to even know of bitstream filter can be used
properly (and more importantly how).

> Please revert.

May I at least make it a #if 0 to keep as documentation of the format?

Greetings,
Reimar D?ffinger