[FFmpeg-cvslog] r11624 - in trunk/libavformat: isom.c isom.h mov.c

[Michael Niedermayer]

On Sat, Jan 26, 2008 at 10:55:10PM +0100, Reimar D?ffinger wrote:
> Hello,
> On Sat, Jan 26, 2008 at 09:30:03PM +0100, michael wrote:
> > Modified: trunk/libavformat/mov.c
> > ==============================================================================
> > --- trunk/libavformat/mov.c	(original)
> > +++ trunk/libavformat/mov.c	Sat Jan 26 21:30:03 2008
> > @@ -624,6 +624,11 @@ static int mov_read_stsd(MOVContext *c, 
> >                  id = codec_get_id(codec_bmp_tags, format);
> >              if (id > 0)
> >                  st->codec->codec_type = CODEC_TYPE_VIDEO;
> > +            else if(st->codec->codec_type == CODEC_TYPE_DATA){
> > +                id = codec_get_id(ff_codec_movsubtitle_tags, format);
> > +                if(id > 0)
> > +                    st->codec->codec_type = CODEC_TYPE_SUBTITLE;
> > +            }
> >          }
> 
> This does not set the codec_id, since the code below does not have a
> CODEC_TYPE_SUBTITLE case and adding one in the trivial way would break
> the DVD subtitle case.

mov and mp4 are a mess ...
first, the code incorrectly skips the ESDS for subtitle streams, that would
be trivial to fix but iam sure this would break something, also it doesnt
help
normally the dvd subtitles should be identified by the object type in esds
but that object type is set to "user private"

uhm, i need to think more about this

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Those who are too smart to engage in politics are punished by being
governed by those who are dumber. -- Plato 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20080126/3748656e/attachment.pgp>