[FFmpeg-cvslog] r11388 - trunk/libavcodec/ac3dec.c

[Justin Ruggles]

Rich Felker wrote:
> On Mon, Jan 07, 2008 at 04:18:59PM +0100, Andreas ?man wrote:
>> jbr wrote:
>>> Author: jbr
>>> Date: Fri Jan  4 00:05:53 2008
>>> New Revision: 11388
>>>
>>> Log:
>>> only check ac3 crc if AVCodecContext.error_resilience > 0
>>>  [...]
>>>      /* check for crc mismatch */
>>> +    if(avctx->error_resilience > 0) {
>> May I suggest that you use the constants available in avcodec.h.
>> Also, since '1' (FF_ER_CAREFUL) is default, perhaps the check should
>> be > FF_ER_CAREFUL.
> 
> I think the intent of ffmpeg is for error resilience to be on by
> default.

I agree, and applied the change accordingly.  There are other more
aggressive checks that could be done to find encoder errors or for cases
that slip through the CRC.  If I implement those, I will most likely put
them under a higher level, but the CRC check is pretty basic and covers
most situations.

-Justin