[FFmpeg-cvslog] r11374 - trunk/libavformat/rmdec.c

[Reimar Döffinger]

Hello,
On Thu, Jan 03, 2008 at 09:49:47AM +0100, Benoit Fouet wrote:
> Rich Felker wrote:
> > On Wed, Jan 02, 2008 at 07:53:12PM +0100, diego wrote:
> >   
> >> Author: diego
> >> Date: Wed Jan  2 19:53:12 2008
> >> New Revision: 11374
> >>
> >> Log:
> >> Merge double-nested if into && condition.
> >> patch by Ronald S. Bultje, rsbultje gmail com
> >>
> >>
> >> Modified:
> >>    trunk/libavformat/rmdec.c
> >>
> >> Modified: trunk/libavformat/rmdec.c
> >> ==============================================================================
> >> --- trunk/libavformat/rmdec.c	(original)
> >> +++ trunk/libavformat/rmdec.c	Wed Jan  2 19:53:12 2008
> >> @@ -716,10 +716,8 @@ resync:
> >>          if (ff_rm_parse_packet (s, st, len, pkt, &seq, &flags, &timestamp) < 0)
> >>              goto resync;
> >>  
> >> -        if(flags&2){
> >> -            if((seq&0x7F) == 1)
> >> +        if(flags&2 && (seq&0x7F) == 1)
> >>     
> >
> > I would be a lot happier with some extra () around the leftmost
> > subexpression..
> 
> i think the way it is written makes reader understand how it should be
> read, without adding some superfluous parentheses...

But IMHO at a slightly higher risk of someone breaking it with some future change,
so I agree with Rich though I don't care much.

Greetings,
Reimar D?ffinger