[FFmpeg-cvslog] r11386 - trunk/libavcodec/aac_ac3_parser.c

[Benjamin Larsson]

Justin Ruggles wrote:
> Michael Niedermayer wrote:
>   
>> On Thu, Jan 03, 2008 at 06:22:42PM -0500, Justin Ruggles wrote:
>> [...]
>> t should check, its ugly but randomizing the variable is worse
>>     
>
> I'm trying to think of a cleaner way to handle downmixed output.  One
> way would be to have different variables for source channels, requested
> channels, and output channels.  It used to be just 1 variable
> representing all 3 ideas, now it's 2 variables, but as long as decoders
> can do downmixing internally and setting requested_channels doesn't
> guarantee anything, it's still not adequate to represent the whole picture.
>
> The decoder can handle it cleanly because it can keep track of the
> source channels internally, but once you get outside the decoder, things
> get messy.
>
> What do you think about adding AVCodecContext.source_channels?
>
> -Justin
>   

I agree, we need to keep track of everything. It is used in my the 
downmix ideas.

MvH
Benjamin Larsson