[FFmpeg-cvslog] r12241 - trunk/libavformat/mov.c

[Michael Niedermayer]

On Tue, Feb 26, 2008 at 08:00:15PM +0100, Reimar D?ffinger wrote:
> On Tue, Feb 26, 2008 at 07:50:14PM +0100, Baptiste Coudurier wrote:
> > Reimar D?ffinger wrote:
> > >> @@ -1451,6 +1529,13 @@ static int mov_read_header(AVFormatConte
> > >>          sc->ffindex = i;
> > >>          mov_build_index(mov, st);
> > >>  
> > >> +        if (sc->dref_id-1 < sc->drefs_count && sc->drefs[sc->dref_id-1].path) {
> > >> +            if (url_fopen(&sc->pb, sc->drefs[sc->dref_id-1].path, URL_RDONLY) < 0)
> > >> +                av_log(s, AV_LOG_ERROR, "stream %d, error opening external essence: %s\n",
> > >> +                       st->index, strerror(errno));
> > >> +        } else
> > >> +            sc->pb = s->pb;
> > > 
> > > This must be a joke. Or do you seriously consider it acceptable for a
> > > demuxer to do url_fopen?!
> > 
> > Please do not whine. Give valid reasons AND suggest another correct way
> > to handle those files.
> 
> Like the fact that this probably can be misused to detect whenever
> someone plays a locally stored file?

You mean something like:
http://analytics.google.com/download_id-reimar_d?ffiner-file-<put your favorite pr0n here>.avi
?
:)

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The misfortune of the wise is better than the prosperity of the fool.
-- Epicurus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20080226/6790161d/attachment.pgp>