[FFmpeg-cvslog] r11903 - in trunk/libavcodec: avcodec.h libmp3lame.c utils.c

Michael Niedermayer michaelni
Thu Feb 14 15:53:01 CET 2008


On Wed, Feb 13, 2008 at 12:28:24PM +0100, Baptiste Coudurier wrote:
> Hi,
> 
> andoma wrote:
> > Author: andoma
> > Date: Mon Feb 11 09:01:07 2008
> > New Revision: 11903
> > 
> > Log:
> > Add 'reservoir' flag to lavc's flags2 controlling whether or not codes may
> > utilize a bit reservoir. Also, make the lame encoder utilize this flag.
> > 
> > patch by Paul Kelly, paul a stjohnspoint d co d uk
[...]
> >      }
> >      lame_set_bWriteVbrTag(s->gfp,0);
> > +    lame_set_disable_reservoir(s->gfp, avctx->flags2 & CODEC_FLAG2_BIT_RESERVOIR ? 0 : 1);
> >      if (lame_init_params(s->gfp) < 0)
> >          goto err_close;
> >  
> 
> Sorry for noticing it so late, but
> isn't !(avctx->flags2 & CODEC_FLAG2_BIT_RESERVOIR) better ?

yes

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Asymptotically faster algorithms should always be preferred if you have
asymptotical amounts of data
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20080214/d63bad3f/attachment.pgp>



More information about the ffmpeg-cvslog mailing list