[FFmpeg-cvslog] r11889 - trunk/libavutil/mem.h

Rich Felker dalias
Mon Feb 11 20:59:49 CET 2008


On Mon, Feb 11, 2008 at 07:50:46PM +0000, M?ns Rullg?rd wrote:
> Rich Felker <dalias at aerifal.cx> writes:
> 
> > On Mon, Feb 11, 2008 at 07:17:18PM +0100, Reimar D?ffinger wrote:
> >> Hello,
> >> On Mon, Feb 11, 2008 at 12:51:08PM -0500, Rich Felker wrote:
> >> > On Mon, Feb 11, 2008 at 11:45:38AM +0100, Reimar D?ffinger wrote:
> >> > > Huh? With my suggestion the gcc variant is the fallback case...
> >> > 
> >> > The fallback case needs to be C, not "GNU C" or "MS Visual C++" or
> >> > whatever they call it now. A plain C build has no need for alignment
> >> > beyond what the compiler provides, nor any need for asm constants
> >> > since there's no asm.
> >> 
> >> I'll agree at once if you change configure so this is the case.
> >> But the fallback case being "plain C but with asm that is sure to crash
> >> because of missing alignment" is idiocy.
> >
> > Umm, does configure really detect the support of asm without actually
> > checking for it?? Somehow I doubt this. It should at least look for
> > the __GNUC stuff or attempt to compile a file with inline asm..
> 
> There are checks for the various instruction sets used by inline asm.
> AFAIK, all inline asm depends on one or more of these checks being
> successful.  If this is not the case, I'd be happy to amend the
> configure script.

Then it seems that having the default case for alignment macros being
pure C would work just fine.

Rich




More information about the ffmpeg-cvslog mailing list