[FFmpeg-cvslog] r11889 - trunk/libavutil/mem.h

Uoti Urpala uoti.urpala
Sun Feb 10 22:47:01 CET 2008


On Sun, 2008-02-10 at 22:16 +0100, Diego Biurrun wrote:
> On Sun, Feb 10, 2008 at 10:11:52PM +0100, Diego Biurrun wrote:
> > Wait, icc defines __GNUC__?!?
> 
> I suggest the following, which is farm more readable IMO even if -
> strictly speaking - it duplicates one line:
> 
> #ifdef __GNUC__
>   #define DECLARE_ALIGNED(n,t,v)       t v __attribute__ ((aligned (n)))
>   #define DECLARE_ASM_CONST(n,t,v)     static const t v attribute_used __attribute__ ((aligned (n)))
> #elif __ICC

icc does define __GNUC__ as it tries to support the same extensions. So
if there is a test for __GNUC__, any icc-specific code must be on the
__GNUC__ side, not the non-__GNUC__ side like in your suggestion.





More information about the ffmpeg-cvslog mailing list