[FFmpeg-cvslog] r11848 - trunk/libavformat/matroskadec.c

[Rich Felker]

On Mon, Feb 04, 2008 at 04:20:03AM +0100, Michael Niedermayer wrote:
> On Mon, Feb 04, 2008 at 03:36:35AM +0100, Luca Barbato wrote:
> > michael wrote:
> > > Author: michael
> > > Date: Mon Feb  4 02:04:27 2008
> > > New Revision: 11848
> > > 
> > > Log:
> > > Remove incorrect cast found by -Wwrite-strings.
> > 
> > > -                put_buffer(&b, (uint8_t *) "TTA1", 4);
> > > +                put_buffer(&b, "TTA1", 4);
> > 
> > "TTA1" isn't uint8_t, put_buffer accepts const unsigned char
> >  (const uint8_t*) would be more correct.
> 
> no no no, you dont do it correctly
> its:
> 
> (void)put_buffer((ByteIOContext *)&b, (const unsigned char*)"TTA1", (int)4);

LMAO this should go in the quotes! :-)

Rich