[FFmpeg-cvslog] r11815 - trunk/libavformat/asf.c

[Reimar Döffinger]

Hello,
On Sat, Feb 02, 2008 at 11:36:29PM +0100, Michael Niedermayer wrote:
> And the #ifdef makes the code much more obfuscated. A unused function never
> points to a bug except by coincidence. It might point to some forgotten old
> code but not more. Theres attribute(unused) for silencing such warnings.

well, it's no problem to change it to av_unused, though this whole thing
IMO raises a few other questions, like what is a CONFIG_MMSH_PROTOCOL
doing in a demuxer at all.
It's not really a problem, but if we ever create libavprotocols or so
this means that lavf like this would now depend on libavprotocols.
Anyway, do we have an agreement to remove the ifdef and instead use
av_unused?

Greetings,
Reimar D?ffinger