[FFmpeg-cvslog] r11815 - trunk/libavformat/asf.c

[Ronald S. Bultje]

Hi,

On Feb 2, 2008 5:36 PM, Michael Niedermayer <michaelni at gmx.at> wrote:

> And the #ifdef makes the code much more obfuscated. A unused function
> never
> points to a bug except by coincidence. It might point to some forgotten
> old
> code but not more. Theres attribute(unused) for silencing such warnings.


attribute(unused) is gcc-specific. Not that I care, I mean, that would be
great also. What I want to get rid of is the warning, I don't care about
whether that's by #ifdef or by attribute(unused) or by eating my socks.

Here's what I hate (make 2>/tmp/log, don't bother fixing the ones I paste
here because they're likely outdated, just run make 2>/tmp/log yourself):
http.c: In function 'http_connect':
http.c:237: warning: pointer targets in passing argument 1 of 'snprintf'
differ in signedness
http.c:240: warning: pointer targets in passing argument 1 of 'strlen'
differ in signedness
rtsp.c: In function 'rtsp_send_cmd':
rtsp.c:768: warning: pointer targets in passing argument 2 of 'url_write'
differ in signedness
rtsp.c: In function 'sdp_probe':
rtsp.c:1368: warning: pointer targets in initialization differ in signedness
rtsp.c:1368: warning: pointer targets in initialization differ in signedness
rtsp.c: In function 'sdp_read_header':
rtsp.c:1399: warning: pointer targets in passing argument 2 of 'get_buffer'
differ in signedness
rtsp.c: In function 'redir_probe':
rtsp.c:1474: warning: pointer targets in assignment differ in signedness
rtp.c: In function 'rtp_check_and_send_back_rr':
rtp.c:439: warning: pointer targets in passing argument 2 of 'put_buffer'
differ in signedness

There's no way I'll ever read the stderr and see if a new warning was added
by some local addition. Effectively, these warnings obfuscate useful gcc
output. by whatever means (except for eating my socks, those are mine!),
please get rid of 'em.

Ronald