[FFmpeg-cvslog] r11815 - trunk/libavformat/asf.c

[Michael Niedermayer]

On Sat, Feb 02, 2008 at 10:59:55PM +0100, Reimar D?ffinger wrote:
> Hello,
> On Sat, Feb 02, 2008 at 10:25:35PM +0100, Michael Niedermayer wrote:
> > On Sat, Feb 02, 2008 at 10:17:46PM +0100, reimar wrote:
> > > Author: reimar
> > > Date: Sat Feb  2 22:17:46 2008
> > > New Revision: 11815
> > > 
> > > Log:
> > > Put is_mms under ifdef CONFIG_MMSH_PROTOCOL, avoids warning:
> > > libavformat/asf.c:112: warning: 'is_mms' defined but not used
> > 
> > Iam not too much in favor of these kind of warning fixes ...
> 
> And I actually am not in favour of this function existing in the first
> place, which probably is part of what made me add this...

You should tell this to the person who wrote the mms patches, and suggest
an alternative.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

When you are offended at any man's fault, turn to yourself and study your
own failings. Then you will forget your anger. -- Epictetus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20080202/c19176d2/attachment.pgp>