[FFmpeg-cvslog] r11815 - trunk/libavformat/asf.c

Ronald S. Bultje rsbultje
Sat Feb 2 22:53:26 CET 2008


On Feb 2, 2008 4:46 PM, Rich Felker <dalias at aerifal.cx> wrote:

> On Sat, Feb 02, 2008 at 10:25:35PM +0100, Michael Niedermayer wrote:
> > On Sat, Feb 02, 2008 at 10:17:46PM +0100, reimar wrote:
> > > Author: reimar
> > > Date: Sat Feb  2 22:17:46 2008
> > > New Revision: 11815
> > >
> > > Log:
> > > Put is_mms under ifdef CONFIG_MMSH_PROTOCOL, avoids warning:
> > > libavformat/asf.c:112: warning: 'is_mms' defined but not used
> >
> > Iam not too much in favor of these kind of warning fixes ...
>
> Agree. cost(#ifdef) >> cost(warning) (and here >> means greater by an
> order of magnitude, not rightshift).


Disagree.

As said before, these sort of warnings are easily fixed, do not obfuscate
actual code (unlike your previously pointed out casts), they do not make
code slower and do not affect binary size (unless your compiler sucks, in
which case it makes it smaller :-) ). So far for the disadvantages.

Advantage as always: these silly warnings make it harder to spot those few
helpful messages from gcc (that svq1 bug is just one of the many; compiling
with -Wall -Werror would have made sure that never went in, because it
relies on a const -> non-const cast). Therefore, please continue fixing
them. I'm extremely happy there's finally some agreement towards making
ffmpeg more developer-friendly. Even outside the svq1 bug, as others have
pointed out, some obscure bugs will be fixed after this effort. That alone
is worth it already.

Ronald




More information about the ffmpeg-cvslog mailing list