[FFmpeg-cvslog] r11814 - trunk/libavformat/http.c

[Rich Felker]

On Sat, Feb 02, 2008 at 09:58:59PM +0100, reimar wrote:
> Author: reimar
> Date: Sat Feb  2 21:58:58 2008
> New Revision: 11814
> 
> Log:
> Missing 'const' in cast.
> 
> 
> Modified:
>    trunk/libavformat/http.c
> 
> Modified: trunk/libavformat/http.c
> ==============================================================================
> --- trunk/libavformat/http.c	(original)
> +++ trunk/libavformat/http.c	Sat Feb  2 21:58:58 2008
> @@ -219,7 +219,7 @@ static int http_connect(URLContext *h, c
>      /* send http header */
>      post = h->flags & URL_WRONLY;
>      auth_b64 = av_malloc(auth_b64_len);
> -    av_base64_encode(auth_b64, auth_b64_len, (uint8_t *)auth, strlen(auth));
> +    av_base64_encode(auth_b64, auth_b64_len, (const uint8_t *)auth, strlen(auth));

Having this cast in the first place is misguided. It should be
removed.. all it does it hurt readability. The 'fixed' version is even
worse because it makes the line longer than 80 chars.

Rich