[FFmpeg-cvslog] r16378 - in trunk/libavformat: rdt.c rmdec.c

Michael Niedermayer michaelni
Mon Dec 29 00:45:19 CET 2008


On Mon, Dec 29, 2008 at 12:24:00AM +0100, rbultje wrote:
> Author: rbultje
> Date: Mon Dec 29 00:23:59 2008
> New Revision: 16378
> 
> Log:
> Fix double free which happens for playback of .rm files after r16365. See
> "rmdec.c: double free" discussion on mailinglist, patch with suggestions
> from Reimar Doffinger.
> 
> Modified:
>    trunk/libavformat/rdt.c
>    trunk/libavformat/rmdec.c
> 
> Modified: trunk/libavformat/rdt.c
> ==============================================================================
> --- trunk/libavformat/rdt.c	Mon Dec 29 00:12:46 2008	(r16377)
> +++ trunk/libavformat/rdt.c	Mon Dec 29 00:23:59 2008	(r16378)
> @@ -438,6 +438,7 @@ static void
>  rdt_free_extradata (PayloadContext *rdt)
>  {
>      ff_rm_free_rmstream(rdt->rmst[0]);
> +    av_free(rdt->rmst[0]);
>      if (rdt->rmctx)
>          av_close_input_stream(rdt->rmctx);
>      av_freep(&rdt->mlti_data);

this really wasnt part of reimars patch
besides it should be av_freep(), as its safer ...


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Dictatorship naturally arises out of democracy, and the most aggravated
form of tyranny and slavery out of the most extreme liberty. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20081229/04553b85/attachment.pgp>



More information about the ffmpeg-cvslog mailing list