[FFmpeg-cvslog] r16239 - in trunk/libavcodec: Makefile i386/dsputil_mmx.c i386/h264_deblock_sse2.asm

[Aurelien Jacobs]

Vitor Sessak wrote:

> darkshikari wrote:
> > Author: darkshikari
> > Date: Fri Dec 19 14:45:13 2008
> > New Revision: 16239
> > 
> > Log:
> > Port x264 deblocking code to libavcodec.  This includes SSE2 luma deblocking code and both MMXEXT and SSE2 luma intra deblocking code for H.264 decoding.  This assembly is available under --enable-gpl and speeds decoding of Cathedral by 7%.
> > 
> > Added:
> >    trunk/libavcodec/i386/h264_deblock_sse2.asm
> > Modified:
> >    trunk/libavcodec/Makefile
> >    trunk/libavcodec/i386/dsputil_mmx.c
> > 
> > Modified: trunk/libavcodec/Makefile
> > ==============================================================================
> > --- trunk/libavcodec/Makefile	(original)
> > +++ trunk/libavcodec/Makefile	Fri Dec 19 14:45:13 2008
> > @@ -404,7 +404,8 @@ MMX-OBJS-$(CONFIG_VP6_DECODER)         +
> >  MMX-OBJS-$(CONFIG_VP6A_DECODER)        += i386/vp3dsp_mmx.o i386/vp3dsp_sse2.o
> >  MMX-OBJS-$(CONFIG_VP6F_DECODER)        += i386/vp3dsp_mmx.o i386/vp3dsp_sse2.o
> >  MMX-OBJS-$(CONFIG_WMV3_DECODER)        += i386/vc1dsp_mmx.o
> > -MMX-OBJS-$(HAVE_YASM)                  += i386/dsputil_yasm.o
> > +MMX-OBJS-$(HAVE_YASM)                  += i386/dsputil_yasm.o \
> > +                                          i386/h264_deblock_sse2.o
> 
> I know I should have pointed out this earlier, but don't this mean this 
> code will be built but unused when configuring whithout "--enable-gpl"?

Yes. And this is a pretty serious issue IMO.
It means that people compiling *without* --enable-gpl still have
good chances to end up with a lib containing GPL code...

Aurel