[FFmpeg-cvslog] r16207 - trunk/libavcodec/h264.c

[Michael Niedermayer]

On Fri, Dec 19, 2008 at 03:05:27AM +0000, M?ns Rullg?rd wrote:
> M?ns Rullg?rd <mans at mansr.com> writes:
> 
> > michael <subversion at mplayerhq.hu> writes:
> >
> >> Author: michael
> >> Date: Thu Dec 18 03:53:18 2008
> >> New Revision: 16207
> >>
> >> Log:
> >> Use the new idct functions (except chroma as it was slower in benchmarks)
> >> cathedral +0.5% speed
> >> aladin +0.6% speed [note aladin has been cat-ed 10 times to reduce the influence
> >> of init time]
> >> Speedup also verified via START/STOP_TIMER (difference was very significant
> >> for the changed parts)
> >
> > This broke H.264 decoding on non-x86.
> 
> More precisely, it broke anything that has asm for the old functions.
> Disabling the new asm on x86 results in the same breakage.

maybe the following (and similar) hacks are responsible:
const int transpose = (h->s.dsp.h264_idct8_add != ff_h264_idct8_add_c); //FIXME ugly
if so, iam not sure how to fix this, simply adding the new functions seems
easyast 

besides, i do also have found that 3 files off the h264 conformance streams
fail with all plain C. I will look into this one (probably tomorrow as its
already quite late)

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I am the wisest man alive, for I know one thing, and that is that I know
nothing. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20081219/a228cd91/attachment.pgp>