[FFmpeg-cvslog] r16100 - in trunk/libavformat: allformats.c avio.h aviobuf.c

[Måns Rullgård]

Diego Biurrun <diego at biurrun.de> writes:

> On Sat, Dec 13, 2008 at 02:55:35PM +0000, M?ns Rullg?rd wrote:
>> diego <subversion at mplayerhq.hu> writes:
>> >
>> > Log:
>> > whitespace cosmetics
>> >
>> > --- trunk/libavformat/allformats.c	(original)
>> > +++ trunk/libavformat/allformats.c	Sat Dec 13 14:39:13 2008
>> > @@ -22,16 +22,16 @@
>> >
>> > -#define REGISTER_MUXER(X,x) { \
>> > -          extern AVOutputFormat x##_muxer; \
>> > -          if(ENABLE_##X##_MUXER)   av_register_output_format(&x##_muxer); }
>> > -#define REGISTER_DEMUXER(X,x) { \
>> > -          extern AVInputFormat x##_demuxer; \
>> > -          if(ENABLE_##X##_DEMUXER) av_register_input_format(&x##_demuxer); }
>> > +#define REGISTER_MUXER(X,x) { extern AVOutputFormat x##_muxer; \
>> > +    if(ENABLE_##X##_MUXER) av_register_output_format(&x##_muxer); }
>> > +
>> > +#define REGISTER_DEMUXER(X,x) { extern AVInputFormat x##_demuxer; \
>> > +    if(ENABLE_##X##_DEMUXER) av_register_input_format(&x##_demuxer); }
>> > +
>> >  #define REGISTER_MUXDEMUX(X,x)  REGISTER_MUXER(X,x); REGISTER_DEMUXER(X,x)
>> > -#define REGISTER_PROTOCOL(X,x) { \
>> > -          extern URLProtocol x##_protocol; \
>> > -          if(ENABLE_##X##_PROTOCOL) register_protocol(&x##_protocol); }
>> > +
>> > +#define REGISTER_PROTOCOL(X,x) { extern URLProtocol x##_protocol; \
>> > +    if(ENABLE_##X##_PROTOCOL) register_protocol(&x##_protocol); }
>> 
>> This looks hideous.
>
> Which part?

Moving the "extern ..." declaration up to the first line.

>> Why did you do that?
>
> 10 space indentation

You could have changed the indentation without moving that
declaration.

-- 
M?ns Rullg?rd
mans at mansr.com