[FFmpeg-cvslog] r15120 - in trunk: [lots of headers]
Stefano Sabatini
stefano.sabatini-lala
Sun Aug 31 19:49:44 CEST 2008
On date Sunday 2008-08-31 15:19:24 +0200, Diego Biurrun wrote:
> On Sun, Aug 31, 2008 at 09:39:48AM +0200, stefano wrote:
> >
> > Log:
> > Rename globally the header inclusion guards.
> >
> > Apply consistently this rule:
>
> This is a common mistake. I don't know any formal grammar rules to
> support this, but at the beginning of a sentence, you should place the
> attribute before the verb, i.e. "globally rename..", "consistently
> apply..", etc.
Thanks Diego, this kind of comments help improving (to improve?) my
grammar.
> > the guard name is obtained from the
> > filename stripping the eventual leading "lib", converting '/' and '.'
> > to '_' and upcasing the resulting name.
>
> uppercasing
Fixed.
> > Headers' guards in the root dir have to be prefixed by "FFMPEG_".
>
> inclusion guards
Fixed differently, now it should read more consistent too.
Regards.
More information about the ffmpeg-cvslog
mailing list