[FFmpeg-cvslog] r14956 - trunk/libavformat/matroskadec.c

[Aurelien Jacobs]

Robert Swain wrote:

> 2008/8/26 Mike Melanson <mike at multimedia.cx>:
> > Michael Niedermayer wrote:
> >> On Mon, Aug 25, 2008 at 11:51:52PM +0200, Aurelien Jacobs wrote:
> >>> Mike Melanson wrote:
> >>>
> >>>> aurel wrote:
> >>>>> Author: aurel
> >>>>> Date: Mon Aug 25 01:57:29 2008
> >>>>> New Revision: 14956
> >>>>>
> >>>>> Log:
> >>>>> matroskadec: don't try to seek to negative timestamp
> >>>>> matroska timestamps are unsigned
> >>>>>
> >>>>>
> >>>>> Modified:
> >>>>>    trunk/libavformat/matroskadec.c
> >>>> Either 14955 or 14956 (both from you) broke the seek regressions.
> >>>> Representative breakage:
> >>> Grmlll... I was pretty sure those commit would change the seek
> >>> regressions. But when I wanted to test this, I just couldn't
> >>> run the test due to the wma regression (floating-point issue IIRC,
> >>> running on amd64).
> >>
> >> Which commit did cause this wma regression test failure?

I thought it was due to r14698 as this was already discussed, and I
got the same md5. But In fact it's not.

> > One of the 3 revisions following 14755 broke WMA. According to an
> > earlier email, it was 14758, specifically.

Almost. It's in fact r14757 which broke reg tests for me.

> Is this only an issue on x86_64? I see no regressions on x86_32.

I can't reproduce it on x86_32 either. It happens only on x86_64
for me:

--- tests/ffmpeg.regression.ref	 2008-08-26 04:16:31.000000000 +0200
+++ tests/data/vsynth.regression 2008-08-26 04:31:40.000000000 +0200
@@ -205,7 +205,7 @@
 353368 ./tests/data/a-flac.flac
 95e54b261530a1bcf6de6fe3b21dc5f6 *./tests/data/flac.vsynth.out.wav
 stddev:    0.00 PSNR:999.99 bytes:  1058444/  1058444
-4435d87463cd6c5407bd88cca241ca56 *./tests/data/a-wmav1.asf
+6f7f3116b801ea641ce14f827de05cce *./tests/data/a-wmav1.asf
 106004 ./tests/data/a-wmav1.asf
 stddev:12251.38 PSNR: 14.56 bytes:  1056812/  1058444
 stddev: 2105.96 PSNR: 29.85 bytes:  1048620/  1058444

Aurel