[FFmpeg-cvslog] r14815 - in trunk: libavcodec/ac3dec.c libavcodec/ac3dec.h libavutil/Makefile

[Michael Niedermayer]

On Sun, Aug 17, 2008 at 06:44:50PM +0100, Alex Beregszaszi wrote:
> On Sun, 2008-08-17 at 19:41 +0200, jbr wrote:
> > Author: jbr
> > Date: Sun Aug 17 19:41:48 2008
> > New Revision: 14815
> > 
> > Log:
> > use LFG instead of Mersenne Twister for AC-3 PRNG
> > 
> > Modified:
> >    trunk/libavcodec/ac3dec.c
> >    trunk/libavcodec/ac3dec.h
> >    trunk/libavutil/Makefile
> > 
> > Modified: trunk/libavcodec/ac3dec.c
> > ==============================================================================
> > --- trunk/libavcodec/ac3dec.c	(original)
> > +++ trunk/libavcodec/ac3dec.c	Sun Aug 17 19:41:48 2008
> > @@ -33,7 +33,6 @@
> >  #include <string.h>
> >  
> >  #include "libavutil/crc.h"
> > -#include "libavutil/random.h"
> >  #include "avcodec.h"
> >  #include "ac3_parser.h"
> >  #include "bitstream.h"
> > @@ -198,7 +197,7 @@ static av_cold int ac3_decode_init(AVCod
> >      ff_mdct_init(&s->imdct_512, 9, 1);
> >      ff_kbd_window_init(s->window, 5.0, 256);
> >      dsputil_init(&s->dsp, avctx);
> > -    av_init_random(0, &s->dith_state);
> > +    av_lfg_init(&s->dith_state, 0);
> 
> Wouldn't it make sense having the same order of parameters here? (I mean
> in the av_init_random and av_lfg_init functions).

yes, patch or commit welcome
PS: i prefer (&s->dith_state, 0);

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Frequently ignored awnser#1 FFmpeg bugs should be sent to our bugtracker. User
questions about the command line tools should be sent to the ffmpeg-user ML.
And questions about how to use libav* should be sent to the libav-user ML.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20080817/a5112753/attachment.pgp>