[FFmpeg-cvslog] r14692 - in trunk: libavcodec/pcm.c tests/regression.sh

[pross at xvid.org]

On Tue, Aug 12, 2008 at 09:22:21AM -0300, Ramiro Polla wrote:
> Hi,
> 
> > the number of decoded U8 samples is
> > calculated using some lazy logic (number of short ints / 2). 
> > 
> > See patch.
> 
> Thanks. I saw this problem when implementing 24-bit support for the MLP 
> encoder. Now the next thing that is missing for the code in GSoC SVN to 
> work with 24-bit samples are convert functions to/from S24. And FFmpeg 
> still seems to be quite stubborn with always choosing 16-bit.
> 
> What would be the best way to generate a 24-bit PCM wav from whatever 
> source, and then just have to do:
> ./ffmpeg_g -i 24bitsample.wav 24bitasample.mlp
> and have FFmpeg pass SAMPLE_FMT_S24 to the encoder?

For now, use:
./ffmpeg -i input.wav -sample_fmt s24 out24.mlp
(and be sure to include SAMPLE_FMTS_S24 in AVCodec->sample_fmts[].)

If you do not specify the -sample_fmt flag, ffmpeg's will default
to SAMPLE_FMT_16. Michael has approved modifications to utils.c to
change the behaviour, but it breaks a couple of the existing encoders.
I will try to find time (tomorrow?) to rework/resubmit this patch.

-- Peter
(A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20080812/49eed0eb/attachment.pgp>