[FFmpeg-cvslog] r14685 - in trunk/libavcodec: avcodec.h utils.c

[Michael Niedermayer]

On Mon, Aug 11, 2008 at 09:16:05AM +0200, Stefano Sabatini wrote:
> On date Monday 2008-08-11 00:49:00 +0100, Robert Swain wrote:
> > 2008/8/10 Michael Niedermayer <michaelni at gmx.at>:
> > > On Sun, Aug 10, 2008 at 11:31:21PM +0100, M?ns Rullg?rd wrote:
> > >> Stefano Sabatini <stefano.sabatini-lala at poste.it> writes:
> > >>
> > >> > On date Sunday 2008-08-10 22:29:43 +0200, superdump wrote:
> > >> >> +void av_log_missing_feature(void *avc, const char *feature, int want_sample)
> > >> >> +{
> > >> >> +    av_log(avc, AV_LOG_WARNING, "%s not implemented. Update your FFmpeg "
> > >> >> +            "version to the newest one from SVN. If the problem still "
> > >> >> +            "occurs, it means that your file has a feature which has not "
> > >> >> +            "been implemented.", feature);
> > >> >> +    if(want_sample)
> > >> >> +        av_log(avc, AV_LOG_WARNING, " If you want to help, upload a sample "
> > >> >> +                "of this file to ftp://upload.mplayerhq.hu/MPlayer/incoming/ "
> > >> >> +                "and contact the FFmpeg-devel mailing list.");
> > >> >> +    av_log(avc, AV_LOG_WARNING, "\n");
> > >> >> +}
> > >> >
> > >> > It's adding a new function to the public API, so it should also bump
> > >> > lavc minor version.
> > >>
> > >> Why is that function public?  It doesn't make sense for something
> > >> external to call it.
> > >
> > > indeed, it shouldnt be in avcodec.h
> > 
> > OK, so revert both commits? Using merge or rm, cp? Can I do both at once?
> 
> Maybe it's better to leave the minor as it is, or we would have two

yes, it does no harm

[..]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The misfortune of the wise is better than the prosperity of the fool.
-- Epicurus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20080811/76bc39c5/attachment.pgp>