[FFmpeg-cvslog] r14685 - in trunk/libavcodec: avcodec.h utils.c

[Måns Rullgård]

Robert Swain wrote:
> 2008/8/11 Michael Niedermayer <michaelni at gmx.at>:
>> On Mon, Aug 11, 2008 at 12:49:00AM +0100, Robert Swain wrote:
>>> 2008/8/10 Michael Niedermayer <michaelni at gmx.at>:
>>> > On Sun, Aug 10, 2008 at 11:31:21PM +0100, M?ns Rullg?rd wrote:
>>> >> Stefano Sabatini <stefano.sabatini-lala at poste.it> writes:
>>> >>
>>> >> > On date Sunday 2008-08-10 22:29:43 +0200, superdump wrote:
>>> >> >> +void av_log_missing_feature(void *avc, const char *feature, int
>>> want_sample)
>>> >> >> +{
>>> >> >> +    av_log(avc, AV_LOG_WARNING, "%s not implemented. Update your
>>> FFmpeg "
>>> >> >> +            "version to the newest one from SVN. If the problem
>>> still "
>>> >> >> +            "occurs, it means that your file has a feature which has
>>> not "
>>> >> >> +            "been implemented.", feature);
>>> >> >> +    if(want_sample)
>>> >> >> +        av_log(avc, AV_LOG_WARNING, " If you want to help, upload a
>>> sample "
>>> >> >> +                "of this file to
>>> ftp://upload.mplayerhq.hu/MPlayer/incoming/ "
>>> >> >> +                "and contact the FFmpeg-devel mailing list.");
>>> >> >> +    av_log(avc, AV_LOG_WARNING, "\n");
>>> >> >> +}
>>> >> >
>>> >> > It's adding a new function to the public API, so it should also bump
>>> >> > lavc minor version.
>>> >>
>>> >> Why is that function public?  It doesn't make sense for something
>>> >> external to call it.
>>> >
>>> > indeed, it shouldnt be in avcodec.h
>>>
>>> OK, so revert both commits? Using merge or rm, cp? Can I do both at once?
>>
>> just move it into another heaeder, leave the function in utils.c
>> it does not belong to libavutil
>
> libavcodec/common.h?

No such file or directory.

-- 
M?ns Rullg?rd
mans at mansr.com