[FFmpeg-cvslog] r14612 - trunk/tests/seek.regression.ref

[Måns Rullgård]

Aurelien Jacobs <aurel at gnuage.org> writes:

> M?ns Rullg?rd wrote:
>
>> Aurelien Jacobs <aurel at gnuage.org> writes:
>> 
>> > M?ns Rullg?rd wrote:
>> >
>> >> Aurelien Jacobs <aurel at gnuage.org> writes:
>> >> 
>> >> > Hi,
>> >> >
>> >> > Sorry for the mail bombing...
>> >> > I wanted to do a major cleanup of matroskadec since a long time and
>> >> > I finally got to it.
>> >> > I tried hard to keep each change small and self contained, hence the
>> >> > huge number of commit.
>> >> >
>> >> > Anyway, the cleanup was worth it. Just some numbers:
>> >> >
>> >> >  ** before **
>> >> > $ wc matroskadec.c
>> >> >   3212   8783 107324 matroskadec.c
>> >> > $ size matroskadec.o
>> >> >    text	   data	    bss	    dec	    hex	filename
>> >> >   39334	     64	      0	  39398	   99e6	matroskadec.o
>> >> >
>> >> >  ** after **
>> >> > $ wc matroskadec.c
>> >> >   1621   5140  57271 matroskadec.c
>> >> > $ size matroskadec.o
>> >> >    text	   data	    bss	    dec	    hex	filename
>> >> >   18748	     64	      0	  18812	   497c	matroskadec.o
>> >> >
>> >> > => both object size and lines of code divided by 2...
>> >> 
>> >> Now it's almost as small as the matroska demuxer I wrote a few years
>> >> ago ;-)
>> >
>> > In fact, that was one of my target :-)
>> >
>> >> I haven't compared feature support, and mine is fairly minimal...
>> >
>> > Lavf's one has some more features (compressed tracks, attachments...)
>> 
>> Did you fix it to not seek needlessly in the file?  Mine doesn't...
>
> I don't remember it seeking needlessly...

IIRC, it used to seek a few times while reading the header, even
though it wasn't strictly needed.  That may have been already changed,
or maybe I'm making things up...

> At least I can assure you that current version don't seek at all
> in the file except to read index or other elements placed at the
> end of the file (only once, during header parsing).

OK, that's good then.

-- 
M?ns Rullg?rd
mans at mansr.com