[FFmpeg-cvslog] r14612 - trunk/tests/seek.regression.ref

[Aurelien Jacobs]

M?ns Rullg?rd wrote:

> Reimar Doeffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de> writes:
> 
> > On Tue, Aug 05, 2008 at 02:43:05AM +0200, aurel wrote:
> >> Author: aurel
> >> Date: Tue Aug  5 02:43:04 2008
> >> New Revision: 14612
> >> 
> >> Log:
> >> matroskadec: update seek regression test to match new ebml parser
> >
> > IMO changes to regression tests should - if possible - contain
> > 1) which revision changed those values

Right. Done.

> > 2) why exactly they changed (just using the ebml parser is not really a reason)

Done.

> > 3) explain why the new values are right and why the old values were wrong.

Well, I don't think the old values where really wrong, but I think the new
ones are slightly more logical.

> 4) should be done in the same commit as the change that changes the
>    test values

Indeed.
When I worked on this patchset, I did know that I would have to update some
patches with new reg test reference, and I planed to do so at the end of
my rework. Then I forgot about it. And I thought about it again, only when
I had launched my commit script.
I think applying this change in a new commit was the best option left to me.
And I did it in a hurry without a good commit message.
Sorry about this.

Aurel