[FFmpeg-cvslog] r14484 - in trunk/libavcodec: audioconvert.c audioconvert.h

[Aurelien Jacobs]

Diego Biurrun wrote:

> On Sun, Aug 03, 2008 at 05:24:19PM +0200, Michael Niedermayer wrote:
> > On Sun, Aug 03, 2008 at 01:55:50PM +0100, M?ns Rullg?rd wrote:
> > > 
> > > Same thing.  Let me try to state exactly what I want the rule to be:
> > > 
> > >   For each type, symbol, or macro used in a file (source or header),
> > >   the file shall contain an #include line guaranteed to provide,
> > >   directly or indirectly, a declaration or definition of the type,
> > >   symbol, or macro.
> > > 
> > > Is this unambiguous enough?

I absolutely agree with this.

> It is what I suggested, or at least tried to.
> 
> We just need to clarify what indirectly providing means.  It should be
> something like "A is documented to provide B and this will never change".

I think that's what M?ns tried to express with "guaranteed to provide".

Now the only problem left with this proposition is that we currently
have no header granting the inclusion of other headers.
We probably all consider that common.h grants the inclusion of inttypes.h,
but it's not written anywhere.
So added to the above definition, we also need a written list of guarantee
such as the following (very incomplete) one:

avutil.h guarantee inclusion of:
  common.h

avcodec.h guarantee inclusion of:
  common.h

avformat.h guarantee inclusion of:
  common.h

common.h guarantee inclusion of:
  inttypes.h
  mem.h

Aurel