[FFmpeg-cvslog] r14500 - in trunk/libavformat: avformat.h ffm.h nut.h oggdec.h os_support.h raw.h rm.h rtp.h rtp_aac.h rtp_h264.h rtp_mpv.h swf.h

[Michael Niedermayer]

On Sat, Aug 02, 2008 at 02:57:28PM +0200, Diego Biurrun wrote:
> On Sat, Aug 02, 2008 at 12:29:30AM +0200, michael wrote:
> > 
> > Log:
> > Revert r14497
> > 	Log:
> > 	Add missing header #includes.
> > Policy violation (change not approved by maintainer)
> > and while discussions where ongoing and no consensus has been reached.
> 
> I have done many similar commits in the past without receiving
> complaints.  Not that I care ...

stdint.h is already required by avcodec.h and avformat.h thus it is not
neccessary to be included redundantly where, avcodec.h, avformat.h or common.h
is already included.
That is, these headers already include all of what they depend on. What you
add is just redundant bloat.

And, as i already said per private mail, my revert with no warning 
was a little too harsh and iam sorry for that. Still your commit was not
correct, especially while discussions about the very subject where ongoing.

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Concerning the gods, I have no means of knowing whether they exist or not
or of what sort they may be, because of the obscurity of the subject, and
the brevity of human life -- Protagoras
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20080802/33692dcf/attachment.pgp>