[FFmpeg-cvslog] r14484 - in trunk/libavcodec: audioconvert.c audioconvert.h

[Michael Niedermayer]

On Sat, Aug 02, 2008 at 06:15:20PM +0200, Diego Biurrun wrote:
> On Sat, Aug 02, 2008 at 05:54:56PM +0200, Michael Niedermayer wrote:
> > On Sat, Aug 02, 2008 at 06:40:13PM +0300, Uoti Urpala wrote:
> > > On Sat, 2008-08-02 at 17:23 +0200, Michael Niedermayer wrote:
> > > > On Sat, Aug 02, 2008 at 02:50:40PM +0200, Diego Biurrun wrote:
> > > > > On Sat, Aug 02, 2008 at 04:25:52AM +0200, Michael Niedermayer wrote:
> > > > > > it also uses lrintf & snprintf thus also needs one way or another
> > > > > > stdio.h and math.h with  _XOPEN_SOURCE >= 600 || _ISOC99_SOURCE defined before
> > > > > > inclusion of math.h
> > > 
> > > Those are standard C, so any special defines are only required if the
> > > default is to use old versions.
> > 
> > no
> > -------
> > Linux Programmer?s Manual                                                             LRINT(3)
> > 
> > NAME
> >        lrint, lrintf, lrintl, llrint, llrintf, llrintl - round to nearest integer
> > 
> > SYNOPSIS
> > [...]
> >        Link with -lm.
> > 
> >    Feature Test Macro Requirements for glibc (see feature_test_macros(7)):
> > 
> >        All functions shown above: _XOPEN_SOURCE >= 600 || _ISOC99_SOURCE; or cc -std=c99
> >        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> > -------
> > > > > These definitions are part of the global CFLAGS, no need to duplicate
> > > > > them.
> > > > 
> > > > until it causes you an hour of work when you try to compile it
> > > > in mplayer that happenes not to set them.
> > > 
> > > MPlayer uses -std=gnu99 with GCC, so no extra defines are needed for
> > > standard C functions. So even if such defines are not set any problems
> > > could only occur if you're using some compiler which MPlayer does not
> > > recognize and which does not support C99 functions by default.
> > 
> > see above, the manual page of lrintf explain it rather clearly, what is
> > needed on linux. I do not know if you propose to drop linux support or
> > if you propose to depend on undocumented options.
> 
> -std=gnu99 is a superset of -std=c99, so no problem.

The manual disagrees with you, it lists _XOPEN_SOURCE, _ISOC99_SOURCE and 
-std=c99 it does not list gnu99


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The worst form of inequality is to try to make unequal things equal.
-- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20080802/4fe4a8d9/attachment.pgp>