[FFmpeg-cvslog] r14484 - in trunk/libavcodec: audioconvert.c audioconvert.h

[Michael Niedermayer]

On Sat, Aug 02, 2008 at 02:53:36PM +0200, Diego Biurrun wrote:
> On Sat, Aug 02, 2008 at 08:18:54AM +0100, Robert Swain wrote:
> > 2008/8/1 Diego Biurrun <diego at biurrun.de>:
> > > On Fri, Aug 01, 2008 at 11:39:27PM +0200, Michael Niedermayer wrote:
> > >> On Fri, Aug 01, 2008 at 06:20:42PM +0200, Diego Biurrun wrote:
> > >> > On Fri, Aug 01, 2008 at 05:01:48PM +0200, Michael Niedermayer wrote:
> > >> > > On Fri, Aug 01, 2008 at 04:37:46PM +0200, Michael Niedermayer wrote:
> > >> > > > On Fri, Aug 01, 2008 at 02:12:21PM +0100, M?ns Rullg?rd wrote:
> > >> > > [...]
> > >> > > > > Now please stop trolling, and get back to coding, which you do very well.
> > >> > > > > Quite frankly though, I doubt you have the experience necessary to for
> > >> > > > > an informed opinion on organisational matters like these.  That a certain
> > >> > > >
> > >> > > > maybe. I do not claim to be an expert in header inclusion rules and do not
> > >> > > > claim to have reviewed dozends of projects what they do and what problems
> > >> > > > it causes. I just see how well it "works" here, and how little the claims
> > >> > > > match reality.
> > >> > >
> > >> > > Also, its interresting to note that the "all files must directly include their
> > >> > > dependancies" rule is a rather recent thing in relation to ffmpeg. ffmpeg has
> > >> > > existed MUCH longer than it, and it has never been a problem for _us_ so one
> > >> > > has to ask what exactly did this rule fix that caused problems before?
> > >> >
> > >> > I can give you one very concrete example that just bit me: I added ffaac
> > >> > support to my local MPlayer tree by importing the SoC stuff into it.
> > >> > Compilation of aac.c failed because it was missing math.h and string.h
> > >> > headers.  But the first error message was about ENOMEM which puzzled me.
> > >> >
> > >> > This did indeed take some time to fix, which could have been avoided if
> > >> > Robert had #included all necessary headers from the start.
> > 
> > To be fair, it took minimal time to fix.
> 
> Whatever you call minimal time.  We spent maybe half an hour on it
> together, I spent something on the order of another half hour on my
> own.  But the point really is that it could easily be avoided.

If it takes you an hour to debug a "missing" include then i think the
problem is elsewhere.

An error about ENOMEM -> missing errno.h include and if you dont know
that, info libc --index-search=ENOMEM tells you, and a grep -r /usr/include
likely would have as well.

a grep in aac* would tell you its not included, and one in all headers
in libav* would have told you its included from common.h ...

I dont think its reasonable to solve this by asking all developers of ffmpeg
to include all headers in all files redundantly because you might want to
rip a file out and use it in mplayer.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Democracy is the form of government in which you can choose your dictator
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20080802/5f6c279d/attachment.pgp>