[FFmpeg-cvslog] r14484 - in trunk/libavcodec: audioconvert.c audioconvert.h

The Wanderer inverseparadox
Sat Aug 2 15:34:34 CEST 2008


Diego Biurrun wrote:

> On Sat, Aug 02, 2008 at 02:55:30PM +0200, Diego Biurrun wrote:
> 
>> On Sat, Aug 02, 2008 at 12:12:11AM +0200, Michael Niedermayer
>> wrote:
>> 
>>> Would it be possible that you could spell out the rule you think
>>> is a rule so we all know beyond doubt if there are exceptions and
>>> if so which exactly.
>> 
>> All files should #include everything they need directly.
> 
> For system headers like inttypes.h that are documented to always
> #include other headers like stdint.h, I consider just inttypes.h
> enough.

What about for non-system headers which are, or could be, "documented"
(that is, explicitly guaranteed) to always include particular other
headers - or, more to the point, provide particular symbols?

I see no reason why we could not use the same "documented to include"
rationale for internal headers as is used for some external ones.
Indeed, I think that would potentially be better.

-- 
       The Wanderer

Warning: Simply because I argue an issue does not mean I agree with any
side of it.

Secrecy is the beginning of tyranny.




More information about the ffmpeg-cvslog mailing list