[FFmpeg-cvslog] r14484 - in trunk/libavcodec: audioconvert.c audioconvert.h

[Michael Niedermayer]

On Fri, Aug 01, 2008 at 05:18:18PM -0400, The Wanderer wrote:
> Michael Niedermayer wrote:
> 
> > On Fri, Aug 01, 2008 at 06:58:42AM -0400, The Wanderer wrote:
> > 
> >> Michael Niedermayer wrote:
[...]
> > Theres a difference between
> > * every header musts somehow include its dependancies
> 
> This is what I (currently believe I) am advocating.

and i do not oppose the rule of 
"every header musts somehow include its dependancies"


> 
> > * every header must directly include its dependancies
> 
> This is something which I may have supported in the past, and may
> support again in the future, but am not presently terribly fond of.

this ("every header must directly include its dependancies")
is what i strongly oppose and what started this thread, peter removed
a #include "avcodec.h" because it was already included by audioconvert.h
and people started flaming about it ...

Besides this rule would lead to many more #include lines and consequently
many more passes over the file and could lead to a slowdown of the
compilation.



> 
> > * no header should include any other header
> 
> This implies "every source file should directly include every header
> file it needs", and I am not in favor of it at all. In theory, if
> followed universally, it could perhaps work; however, A) as I believe
> others have mentioned, it leads to bitrot includes when formerly-needed
> symbols cease to be needed but the fact that a particular header is
> unnecessary goes unnoticed, and B) since many widely-used headers (at
> the very least, glibc and the Linux kernel) do not do this, it is not
> and cannot be arbitrarily made to be followed universally.

The rule of including all things directly would likely lead to bitrot
as well for the same reasons as here.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I count him braver who overcomes his desires than him who conquers his
enemies for the hardest victory is over self. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20080801/45337ca6/attachment.pgp>