[FFmpeg-cvslog] r14484 - in trunk/libavcodec: audioconvert.c audioconvert.h

[Michael Niedermayer]

On Fri, Aug 01, 2008 at 02:12:21PM +0100, M?ns Rullg?rd wrote:
> 
> Michael Niedermayer wrote:
> > On Fri, Aug 01, 2008 at 09:39:16AM +0100, M?ns Rullg?rd wrote:
> >> Michael Niedermayer <michaelni at gmx.at> writes:
> >>
> >> > The only reason why its not causing a problem is plain because its not
> >> > done, our headers luckily do in general not include all the headers they
> >> > somehow depend on.
> >>
> >> Actually, *all* our headers #include their dependencies.  That's what
> >> "make checkheaders" makes sure.
> >
> > avcodec.h does not include inttypes or stdint directly but use int64_t
> > and iam sure it would be easier to find headers missing dependencies
> > than ones listing all.
> 
> avcodec.h includes common.h, which does include stdint.h.  As I said,

no, avcodec.h does not directly include common.h
it includes avutil.h that includes common.h which includes inttypes.h

Its kinda ironic that you know the header inclusion chains we have nowadays
as well as i aka not at all. (without RTFS of course, anyone can figure it
out by RTFS ...)


> common.h is a special case.  Its purpose is to avoid duplicating
> code that would have to be in practically every file otherwise, and
> this includes including stdint.h.

its inttypes.h which it does include, be that correct or not but its not
stdint.h. It certainly could be annoying if stdint is available but inttypes
is not in some build environment ...


> 
> Now please stop trolling, and get back to coding, which you do very well.
> Quite frankly though, I doubt you have the experience necessary to for
> an informed opinion on organisational matters like these.  That a certain

maybe. I do not claim to be an expert in header inclusion rules and do not
claim to have reviewed dozends of projects what they do and what problems
it causes. I just see how well it "works" here, and how little the claims
match reality.

also a quick grep indicates that i have 49 .{c,h} files that contain int64_t
but not stdint, inttypes nor common.h in libavcodec. Not sure how many
exceptions ive missed that may be used in the new system as substitutions
for inttypes.



[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Old school: Use the lowest level language in which you can solve the problem
            conveniently.
New school: Use the highest level language in which the latest supercomputer
            can solve the problem without the user falling asleep waiting.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20080801/c12677d8/attachment.pgp>