[FFmpeg-cvslog] r14484 - in trunk/libavcodec: audioconvert.c audioconvert.h

Michael Niedermayer michaelni
Fri Aug 1 15:10:36 CEST 2008


On Fri, Aug 01, 2008 at 06:58:42AM -0400, The Wanderer wrote:
> Michael Niedermayer wrote:
> 
> > On Thu, Jul 31, 2008 at 05:00:40PM -0400, The Wanderer wrote:
> > 
> >> Michael Niedermayer wrote:
[...]
> > The advantage of this is purely "because its the right way".
> 
> And just why is it that it is the right way?

You said "If a header needs something then it should provide that thing,
either by defining it directly or (more practically) by including
another header which already defines it. A header which fails to do so
is, IMO, broken."

I felt that this was an argument based on "because it should be done
that way"


[...]
> >> cetera. If a header needs something then it should provide that
> >> thing, either by defining it directly or (more practically) by
> >> including another header which already defines it. A header which
> >> fails to do so is, IMO, broken.
> > 
> > Do you have a argument beyond "is broken" vs. "is the right way"?
> 
> Perhaps a few, but Uoti has made a few which seem sensible to me
> (although also at least one which does not). The fact that Uoti appears
> to agree with me is enough to lead me to doubt my own position, but I'm
> not giving up on it yet. ^_^

;)

The thing that really annoys me is that we ended up with some developers
trying to enforce a rule of "every file includes all its dependancies
directly" while this is
1. not done currently and checkheaders does not check it either.
2. there is no consensus nor was there a vote nor has it been decided by
   the evil ffmpeg maintainer.
3. if it would really be done strictly it would likely lead to problems,
   long lists of includes and be a nightmare to keep in sync.

What checkheaders checks is that headers somehow compile IIRC, that doesnt
distiguish between how a header includes its dependancies.

Theres a difference between
* every header musts somehow include its dependancies
* every header must directly include its dependancies
* no header should include any other header


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No great genius has ever existed without some touch of madness. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20080801/29b48b56/attachment.pgp>



More information about the ffmpeg-cvslog mailing list