[FFmpeg-cvslog] r12972 - trunk/libavformat/mov.c

[Reimar Döffinger]

On Fri, Apr 25, 2008 at 07:37:00PM +0200, Baptiste Coudurier wrote:
> Diego Biurrun wrote:
> > Just adding something like "update comment:" to your commit message
> > would do wonders.
> 
> And here I again don't agree with you, if I would adopt your idea,
> adding only "update comment:" is clearly not sufficient because it does
> not illustrate the removed comment.

An "update comment:" has two advantages:
1) I know it is only "cosmetic", so if I have little time I might not
even bother reading the patch
2) When reading the patch I know I have to look to the right of the line
for changes.

> The diff with the commit message are clearly explicit, repeating the
> diff is useless and waste of bytes/network traffic ;)

Well, IMO as it is the commit message is a waste of (whatever). Just a
"." as commit message would have been no worse, actually maybe less
confusing because it would have been one less thing to read and
understand.