[FFmpeg-cvslog] r12972 - trunk/libavformat/mov.c

[Diego Biurrun]

On Fri, Apr 25, 2008 at 07:02:15PM +0200, Baptiste Coudurier wrote:
> Diego Biurrun wrote:
> > On Fri, Apr 25, 2008 at 06:52:31PM +0200, bcoudurier wrote:
> >> Log:
> >> yes it is true for mp4
> > 
> > This commit message does not make sense on its own...
> 
> Well, I do think that the commit message cannot be separated from the
> corresponding diff. Don't you think ?

No, that's precisely the point.  When you are looking at the output of
'svn log', the messages should make sense on its own without having to
look at the diffs.  If you have to look through all the diffs to make
sense of commit messages, you might as well leave them out entirely.

If you want to see an example of how not to do it, look at early MPlayer
svn history.  When you have multiple commit messages that just say
"10l", using version control is no longer very useful.

Just adding something like "update comment:" to your commit message
would do wonders.

So to answer your question: Sometimes commit messages cannot be separated
from the diffs, but they should be written in a way that this is
possible.  If they do not make sense on their own, they are bad and
should be rewritten.

Diego