[FFmpeg-cvslog] r12871 - trunk/libavcodec/alac.c
Vitor Sessak
vitor1001
Thu Apr 17 20:59:45 CEST 2008
Michael Niedermayer wrote:
> On Thu, Apr 17, 2008 at 08:20:25PM +0200, Vitor Sessak wrote:
>> Vitor Sessak wrote:
>>> michael wrote:
>>>> Author: michael
>>>> Date: Thu Apr 17 04:40:50 2008
>>>> New Revision: 12871
>>>>
>>>> Log:
>>>> more senseless code
>>>> One wonders how such stuff gets past the reviews ...
>
>>> I suppose that you remember that one year ago, the main decoding loop was
>>> triplicated (!): once for mono and once for each stereo channel.
>
> no i dont remember, which commit was that exactly?
It was 9576, 9724-9727. Also there was an av_log2() reimplementation
removed in 9735.
>>> Well, since you are at it, the attached patch removes a unneeded wrapper
>>> around av_log2().
>> Oops, I missed an obvious simplification. This one is better.
>
> ok
Commited. Now this one removes some unneeded vars.
-Vitor
-------------- next part --------------
A non-text attachment was scrubbed...
Name: alac_simpl3.diff
Type: text/x-patch
Size: 1930 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20080417/75e0823a/attachment.bin>
More information about the ffmpeg-cvslog
mailing list