[FFmpeg-cvslog] r12838 - in trunk/libavcodec: cabac.h h264.c i386/h264_i386.h

[Ivan Kalvachev]

On Tue, Apr 15, 2008 at 4:51 PM, heydowns <subversion at mplayerhq.hu> wrote:
> Author: heydowns
>  Date: Tue Apr 15 15:51:41 2008
>  New Revision: 12838
>
>  Log:
>  Move decode_significance_x86() and decode_significance_8x8_x86() to
>  i386-specific file from cabac.h.
>  New file is h264-oriented and only included from h264.c
>  Resolves compilation when configured with --disable-optimizations due to
>  decode_significance_8x8_x86 using last_coeff_flag_offset_8x8, which is
>  only defined in h264.c
>
>
>  Added:
>    trunk/libavcodec/i386/h264_i386.h
>  Modified:
>    trunk/libavcodec/cabac.h
>    trunk/libavcodec/h264.c
>
[...]
>  Added: trunk/libavcodec/i386/h264_i386.h
>  ==============================================================================
>  --- (empty file)
>  +++ trunk/libavcodec/i386/h264_i386.h   Tue Apr 15 15:51:41 2008


I believe that the preferable way of splitting files is using "svn
copy" and then removing unneeded from the copied file, just like you
do with the original.  (hopefully removing different code in both
files ;)

This way the svn blame would not blame you for the errors in (asm)
code you haven't written.

I'm not sure if this requirement is written anywhere in ffmpeg
documentation. Maybe it should.