[FFmpeg-cvslog] r12759 - in trunk/libavcodec: aac_ac3_parser.c?aac_ac3_parser.h aac_parser.c ac3_parser.c

[Michael Niedermayer]

On Thu, Apr 10, 2008 at 12:27:17AM +0200, Michael Niedermayer wrote:
> On Thu, Apr 10, 2008 at 01:00:03AM +0200, Bartlomiej Wolowiec wrote:
> > On ?roda, 9 kwietnia 2008, Michael Niedermayer wrote:
> > > 1. the demuxer seems buggy its output with seeking and normal linear
> > > playback differs. A fix for this MUST be in the demuxer.
> > >
> > > 2. your frame_in_buffer code is buggy, it causes random number of parsed
> > > bytes to be returned.
> > > Hint you cannot change buf_size.
> > >
> > > 3. why is need_next_header set for AC-3 ?
> > >
> > > 4. The return value of ff_combine_frame is ignored. This causes at least a
> > > lost packet at EOF.
> > >
> > > I suspect that the best course of action is to revert the changes up to the
> > > point where the regression tests pass again.
> > > Next the rm demuxer must be fixed which will likely change the regression
> > > checksums, which need to be updated after confirming that the rm demuxer
> > > works equally well or better.
> > > And last the parser should be commited again. (but of course only if
> > > regressions pass, if they dont the bugs causing the failure must be found
> > > and fixed similar to the rm demxuer _before_ commiting the parser)
> > 
> > 1.I'm totally disorientated in this code, so I think that maybe someone else 
> > shold get it?
> 
> Ill look at it, I think i know approximately what is going wrong.

I think ive fixed the issue in the rm demuxer.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

There will always be a question for which you do not know the correct awnser.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20080410/3ce601b5/attachment.pgp>