[FFmpeg-cvslog] r12758 - in?trunk/libavcodec:?aac_ac3_parser.c?aac_ac3_parser.h aac_parser.c?ac3_parser.c

[Michael Niedermayer]

On Mon, Apr 07, 2008 at 07:59:31PM +0200, Michael Niedermayer wrote:
> On Mon, Apr 07, 2008 at 07:55:44PM +0200, Bartlomiej Wolowiec wrote:
> > On poniedzia?ek, 7 kwietnia 2008, Michael Niedermayer wrote:
> > > On Mon, Apr 07, 2008 at 02:52:39PM +0200, Bartlomiej Wolowiec wrote:
> > > > On poniedzia?ek, 7 kwietnia 2008, Michael Niedermayer wrote:
> > > > > Explain what exactly your patch corrects.
> > > > > One bug i see is that your sync functions are off by one byte, loosing
> > > > > 1 bytes and thus returing 1 byte to late. (that is header_size+1)
> > > >
> > > > ok, first patch corrects a situation when in buffer there is no data,
> > > > data is not send.
> > >
> > > I dont understand you, your patch just looks wrong. What is it that the
> > > parser is feeded with as input that causes a problem?
> > > It cant send "no data".
> > 
> > Maybe I'm wrong but I mean a situation when after seek parser gets frame, but 
> > with 4 bytes shift. Then it sends this 4 bytes as a first frame and correct 
> > frame as a second frame.
> 
> That explanation makes more sense, the parser gets as input 4 bytes "junk" and
> then a valid frame, it returns these 4 bytes and then seperately the frame.
> No bug here, this behavior is correct.

After rethinking this, i realize we cannot just output these 4 bytes as a
frame as it would cause the timestamp to be mis-associated :(
So your patch is ok, feel free to commit!

The rm demuxer is likely buggy anyway and also the one large frame looks
odd but these are seperate issues.

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Breaking DRM is a little like attempting to break through a door even
though the window is wide open and the only thing in the house is a bunch
of things you dont want and which you would get tomorrow for free anyway
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20080407/d107ffa2/attachment.pgp>