[FFmpeg-cvslog] r12758 - in trunk/libavcodec:?aac_ac3_parser.c?aac_ac3_parser.h aac_parser.c ac3_parser.c

[Michael Niedermayer]

On Mon, Apr 07, 2008 at 02:52:39PM +0200, Bartlomiej Wolowiec wrote:
> On poniedzia?ek, 7 kwietnia 2008, Michael Niedermayer wrote:
> > Explain what exactly your patch corrects.
> > One bug i see is that your sync functions are off by one byte, loosing 1
> > bytes and thus returing 1 byte to late. (that is header_size+1)
> 
> ok, first patch corrects a situation when in buffer there is no data, data is 
> not send. 

I dont understand you, your patch just looks wrong. What is it that the
parser is feeded with as input that causes a problem?
It cant send "no data".


> I send also correction about which you've told me, the one-byte 
> bug.

Yes, that looks ok. You can commit that part


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I know you won't believe me, but the highest form of Human Excellence is
to question oneself and others. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20080407/39b5ed14/attachment.pgp>