[FFmpeg-cvslog] r10987 - in trunk/libavcodec: intrax8.c intrax8huf.h

[Diego Biurrun]

On Sat, Nov 10, 2007 at 01:07:02PM +0100, Diego Biurrun wrote:
> On Sat, Nov 10, 2007 at 02:15:33AM -0500, Rich Felker wrote:
> > On Sat, Nov 10, 2007 at 02:02:36AM +0100, aurel wrote:
> > > 
> > > Log:
> > > make some tables static
> > > 
> > > --- trunk/libavcodec/intrax8huf.h	(original)
> > > +++ trunk/libavcodec/intrax8huf.h	Sat Nov 10 02:02:36 2007
> > > @@ -22,7 +22,7 @@
> > >  #include <inttypes.h>
> > >  
> > >  
> > > -const uint16_t ff_x8_orient_lowquant_table[4][12][2]={
> > > +static const uint16_t x8_orient_lowquant_table[4][12][2]={
> > >      {//0
> > >          {0x0000,  1}, {0x0004,  3}, {0x0005,  3}, {0x000C,  4},
> > >          {0x000D,  4}, {0x0038,  6}, {0x001D,  5}, {0x0039,  6},
> > 
> > Why are these in a header file to begin with? Headers are for defining
> > interfaces to be shared between modules. Data used by the
> > implementation belongs directly in the .c file...
> 
> It's bad style, that's all :)

Patch coming up in a moment...

Diego