[FFmpeg-cvslog] r8985 - in trunk: configure libavcodec/Makefile libavcodec/cabac.h libavcodec/h264.c libavcodec/h264.h libavcodec/h264_parser.c libavcodec/h264_parser.h

[Aurelien Jacobs]

On Fri, 11 May 2007 09:26:59 +0200
Diego Biurrun <diego at biurrun.de> wrote:

> On Fri, May 11, 2007 at 12:26:44AM +0200, aurel wrote:
> > 
> > Log:
> > split h264.c to move parser in its own file
> 
> I had an identical change in my local tree, oh well ...
> 
> > Added:
> >    trunk/libavcodec/h264.h
> >       - copied, changed from r8983, /trunk/libavcodec/h264.c
> >    trunk/libavcodec/h264_parser.c
> >       - copied, changed from r8983, /trunk/libavcodec/h264.c
> >    trunk/libavcodec/h264_parser.h
> >       - copied, changed from r8983, /trunk/libavcodec/h264.c
> 
> Copying h264_parser.h is overkill IMO, they basically just share the
> license header.

They also share the doxygen documentation of ff_h264_find_frame_end().
I admit this is not much, but h264_parser.h is really a descendent of
h264.c.
Well, I didn't realized that h264.c was so big and that it would
generate a so big commit mail.

> > --- trunk/libavcodec/h264.c	(original)
> > +++ trunk/libavcodec/h264.c	Fri May 11 00:26:44 2007
> > @@ -30,7 +30,9 @@
> >  #include "dsputil.h"
> >  #include "avcodec.h"
> >  #include "mpegvideo.h"
> > +#include "h264.h"
> >  #include "h264data.h"
> > +#include "h264_parser.h"
> >  #include "golomb.h"
> >  
> >  #include "cabac.h"
> 
> I think the #includes that are in h264.h can be removed from the .c file
> now.

I generaly prefer keeping all the explicit includes needed by the .c file,
but you can remove them if you want.

Aurel